-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Conversation
82776db
to
5664652
Compare
5664652
to
11e9383
Compare
1beb4d5
to
41d5736
Compare
0bcc67a
to
8f5f919
Compare
Well done @stefanprodan - you got this done in next to no time! |
- use 4 Kubernetes Kind cluster for e2e tests - store Flux container image and cache dir in artifacts - download artifacts in e2e jobs to avoid rebuilding binaries and containers - cleanup artifacts daily
0de390a
to
61b5ce8
Compare
needs: unit-testing | ||
strategy: | ||
matrix: | ||
test: ['10_* 11_* 12_*', '13_* 14_*', '15_* 16_* 17_*', '20_* 21_* 22_*'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would something like
test: ['1/4', '2/4', '3/4', '4/4']
be an option (with additional logic added to run-gh.bash
)? This would make (newly) added tests run without (forgetting) to add them here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've balanced the tests to take the same amount of time, for example running 15 in shard 2 will take 18m
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should refactor the tests and have the balancing logic in bash, but this can come later.
GitHub Actions migration (ref: #2944):
GH Actions specific changes:
Conclusions:
sudo killall apt-get
, apt-get doesn't hang like in CircleCIOverall I'm happy with GitHub Actions even though it was a painful migration.