This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR: Use
fluxcd/flux:gitops-engine-903b4f82
to give it a try (I will be updating this image regularly)This is the Flux counterpart of argoproj/argo-cd#3066
The code in this PR is not battle-tested yet, but it should be fully functional and is ready to test.
The GitOps Engine uses Argo as the reconciliation engine, and as such, it responds to the same annotations. Those currently are:
argocd.argoproj.io/hook
argocd.argoproj.io/hook-delete-policy
argocd.argoproj.io/compare-options
argocd.argoproj.io/sync-options
argocd.argoproj.io/sync-wave
We still need to ponder whether it makes sense for Flux to respond to those annotations and keep the same behavior as Argo. What's certain is that if we keep those annotations, the
argocd.argoproj.io
prefix will be made Flux-specific or neutral.The GitOps Engine provides a watcher-backed cache to query the Kubernetes API server. As a result, we expect Flux to put considerably less pressure on the API server and etcd.
I will be updating this PR description with the latest Flux docker image including this cases in case
TODO:
--kubernetes-kubectl
flag is currently ignored, until GitOps engine accepts akubectl
binary as a way to interact with the clusterargocd.argoproj.io
prefix to something Flux-specific or neutralgo.mod
hacks which were introduced