This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Let people explicitly include images to scan #2850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squaremo
force-pushed
the
include-image
branch
from
42a3189 to
ffda95f
Compare
Currently there's an option to exclude specific images, which has a handy default of excluding the Kubernetes components' images. But if you only ever care about your specific images, it's probably going to be easier to supply a list of images to _include_. This commit adds the flag `--registry-include-image`, and a tiny abstraction so that the exclude/include logic can be applied to image scanning.
squaremo
force-pushed
the
include-image
branch
from
ffda95f to
f992162
Compare
|
Finally! Oh my this is so awesome.. Thank you! I never got the ignore flag to work properly! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there's an option to exclude specific images, which has a
handy default of excluding the Kubernetes components' images. But if
you only ever care about your specific images, it's probably going to
be easier to supply a list of images to include.
This commit adds the flag
--registry-include-image, and a tinyabstraction so that the exclude/include logic can be applied to image
scanning.