This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Log start of cluster sync #2823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To give some more context, I spent time looking at all the wrong places why the cluster wasn't getting updated until I finally got Delve and narrowed down the issue. The following 2 messages were actually not very helpful in understanding why the images were stuck at their old version: Having those messages after a message saying "Trying/Attempting sync..." with specific git versions would have helped me massively narrow down on the issue. |
hiddeco
reviewed
Feb 5, 2020
hiddeco
reviewed
Feb 6, 2020
|
Can you please smash your commits together, edit the commit message and remove the issue links from it (to prevent endless pings to the issues from our friendly OSS neighbours), and rebase the result on |
hiddeco
approved these changes
Feb 6, 2020
This adds a log line to sync similar to update. It's helpful to operators to understand at which commit the cluster is stuck should any errors occur with cluster sync, such as k8s internal issues.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's helpful to operators to understand at which commit the cluster is
stuck should any errors occur with cluster sync, such as k8s internal
issues: