This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Honor KUBECONFIG env variable in fluxd #2741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, delegate the creation of incluster configuration to the Kubernetes library. As a result, we are not making use of the `--in-cluster` argument anymore. Both the `--in-cluster` and `--kube-config` arguments have been deprecated (you can use the `KUBECONFIG` env variable instead).
2opremio
changed the title
tonyffrench
reviewed
Jan 17, 2020
| if *k8sInCluster && !httpGitURL { | ||
| namespace, err := ioutil.ReadFile("/var/run/secrets/kubernetes.io/serviceaccount/namespace") | ||
| fileinfo, err := os.Stat(k8sInClusterSecretsBaseDir) | ||
| isInCluster := err != nil && fileinfo.IsDir() |
There was a problem hiding this comment.
I think you meant isInCluster := err == nil && fileinfo.IsDir() ... curious how a change so broken could make it to master ?
There was a problem hiding this comment.
Because you didn't take part in the review :)
Now seriously, my bad. This didn't get caught by the end to end tests because we generate our own ssh key there.. we should add one covering ssh key generation.
Thanks for reporting it and sorry for the inconvenience.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, delegate the creation of incluster configuration to the Kubernetes library.
As a result, we are not making use of the
--in-clusterargument anymore. Both the--in-clusterand--kube-configarguments have been deprecated (you can use theKUBECONFIGenv variable instead).Overrides #2621