Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Upgrade aws-sdk-go to support IRSA (IAM Roles for Service Accounts) #2664

Merged
merged 1 commit into from
Dec 12, 2019
Merged

Upgrade aws-sdk-go to support IRSA (IAM Roles for Service Accounts) #2664

merged 1 commit into from
Dec 12, 2019

Conversation

aackerman
Copy link
Contributor

…eatures of AWS EKS

This blog post outlines the IAM Roles for Service Accounts feature for AWS EKS. The post also states the minimum version of aws-sdk-go that supports these features is 1.23.13. These changes upgrade aws-sdk-go to the latest 1.25.48 to support those features.

To make the changes I did the following and everything reported fine on macOS.

go get -u github.com/aws/aws-sdk-go
make
make test

Please bear with me if this isn't the expected approach, I don't have a lot of experience with go.

@hiddeco
Copy link
Member

hiddeco commented Dec 9, 2019

@aackerman can you please do the following:

  1. run go mod tidy to get rid of the // indirect references in go.mod, and append it to the existing commit
  2. rebase on top of master so that the branch is no longer out-of-date

@aackerman
Copy link
Contributor Author

@hiddeco you got it 👍

@2opremio
Copy link
Contributor

2opremio commented Dec 11, 2019

@aackerman I was about to merge this but there are conflicts with master.

Sorry about that. Would you mind rebasing?

@aackerman
Copy link
Contributor Author

@2opremio you got it 👍

@hiddeco
Copy link
Member

hiddeco commented Dec 11, 2019

@aackerman I merged a PR right after you rebased, sorry about that. Can you re-do the rebase? Was going to do it myself but I think you got branch sharing disabled as I am unable to checkout this pull request.

❯ hub checkout https://github.com/fluxcd/flux/pull/2664
remote: Enumerating objects: 4, done.
remote: Counting objects: 100% (4/4), done.
remote: Total 4 (delta 3), reused 4 (delta 3), pack-reused 0
Unpacking objects: 100% (4/4), done.
From github.com:fluxcd/flux
 ! [rejected]          refs/pull/2664/head -> aackerman/upgrade-aws-sdk  (non-fast-forward)

@aackerman
Copy link
Contributor Author

@hiddeco maybe this will be the last one :)

@hiddeco hiddeco added this to the 1.17.0 milestone Dec 11, 2019
@hiddeco hiddeco changed the title Upgrade aws-sdk-go to support IRSA (IAM Roles for Service Accounts) f… Upgrade aws-sdk-go to support IRSA (IAM Roles for Service Accounts) Dec 11, 2019
@2opremio 2opremio merged commit 9de870a into fluxcd:master Dec 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants