Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

e2e: test git gpg commit and tag signing #2567

Merged
merged 3 commits into from
Nov 1, 2019
Merged

e2e: test git gpg commit and tag signing #2567

merged 3 commits into from
Nov 1, 2019

Conversation

hiddeco
Copy link
Member

@hiddeco hiddeco commented Oct 31, 2019

No description provided.

@hiddeco hiddeco force-pushed the e2e/gpg-signing branch 4 times, most recently from 713c03a to 5673339 Compare October 31, 2019 14:52
@hiddeco
Copy link
Member Author

hiddeco commented Oct 31, 2019

@2opremio this is ready for another round of review.

test/e2e/lib/gpg.bash Outdated Show resolved Hide resolved
@2opremio
Copy link
Contributor

I only have very minor stuff. Maybe it's worth waiting until #2569 to use the git access

@hiddeco hiddeco force-pushed the e2e/gpg-signing branch 4 times, most recently from 7eb767e to 5b321d0 Compare November 1, 2019 15:17
@2opremio
Copy link
Contributor

2opremio commented Nov 1, 2019

12_sync.bats and 12_commit_signing.bats have a clashing prefix (sorry), can you please disambiguate them? No strong opinions, but I think that gpg is and advanced feature and probably should be tested later (justifying a second digit change).

@2opremio
Copy link
Contributor

2opremio commented Nov 1, 2019

Really minor stuff. Otherwise it LGTM!!

Thanks a lot @hiddeco the e2e tests are starting to look great!

@@ -48,6 +47,7 @@ function setup() {

function teardown() {
kill "$git_port_forward_pid"
unset GIT_SSH_COMMAND
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just FYI (sorry I missed it before), I don't think this is necessary because each test is run in its own process, see https://github.com/bats-core/bats-core#writing-tests

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was aware of this but still added it for some reason :-S. Will remove it in an upcoming PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, no worries!!

@hiddeco hiddeco merged commit fd0bb42 into master Nov 1, 2019
@hiddeco hiddeco deleted the e2e/gpg-signing branch November 1, 2019 16:13
@2opremio 2opremio added this to the 1.16.0 milestone Nov 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants