-
Notifications
You must be signed in to change notification settings - Fork 1.1k
e2e: test git gpg commit and tag signing #2567
Conversation
dd748a9
to
51a57eb
Compare
713c03a
to
5673339
Compare
@2opremio this is ready for another round of review. |
I only have very minor stuff. Maybe it's worth waiting until #2569 to use the git access |
7eb767e
to
5b321d0
Compare
5b321d0
to
a3007e6
Compare
|
Really minor stuff. Otherwise it LGTM!! Thanks a lot @hiddeco the e2e tests are starting to look great! |
eff59f6
to
5e4e9bc
Compare
@@ -48,6 +47,7 @@ function setup() { | |||
|
|||
function teardown() { | |||
kill "$git_port_forward_pid" | |||
unset GIT_SSH_COMMAND |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just FYI (sorry I missed it before), I don't think this is necessary because each test is run in its own process, see https://github.com/bats-core/bats-core#writing-tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was aware of this but still added it for some reason :-S. Will remove it in an upcoming PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, no worries!!
No description provided.