This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Make sync operations timeout configurable #2481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanprodan
force-pushed
the
sync-timeout
branch
from
86f37b2 to
e0ac4fa
Compare
|
In #1857, where the timeouts were originally reported, we discussed ways of optimization instead of making it a configurable flag. However, shortly after this the manifest factorization feature was introduced, which gives people the power to run anything during sync. As optimizing the unknown is a hard thing to do, I think this change now is the obvious (and most easy) solution. |
stefanprodan
force-pushed
the
sync-timeout
branch
2 times, most recently
from
7d58ab8 to
a378fc9
Compare
hiddeco
approved these changes
Sep 26, 2019
stefanprodan
force-pushed
the
sync-timeout
branch
from
a378fc9 to
df258d6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
--sync-timeoutto fluxd command flags andsync.timeoutto the Helm chart (defaults to1msame as before).Workaround for: #2477 and #1857