Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Deprecate install --git-paths and use git-path instead #2392

Merged
merged 1 commit into from
Aug 22, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions cmd/fluxctl/install_cmd.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ fluxctl install --git-url '[email protected]:<your username>/flux-get-started' | ku
"Git branch to be used by Flux")
cmd.Flags().StringSliceVarP(&opts.GitPaths, "git-paths", "", []string{},
"Relative paths within the Git repo for Flux to locate Kubernetes manifests")
cmd.Flags().StringSliceVarP(&opts.GitPaths, "git-path", "", []string{},
"Relative paths within the Git repo for Flux to locate Kubernetes manifests")
cmd.Flags().StringVarP(&opts.GitLabel, "git-label", "", "flux",
"Git label to keep track of Flux's sync progress; overrides both --git-sync-tag and --git-notes-ref")
cmd.Flags().StringVarP(&opts.GitUser, "git-user", "", "Flux",
Expand All @@ -37,6 +39,11 @@ fluxctl install --git-url '[email protected]:<your username>/flux-get-started' | ku
"Email to use as git committer")
cmd.Flags().StringVarP(&opts.Namespace, "namespace", "", getKubeConfigContextNamespace("default"),
"Cluster namespace where to install flux")

// Hide and deprecate "git-paths", which was wrongly introduced since its inconsistent with fluxd's git-path flag
cmd.Flags().MarkHidden("git-paths")
cmd.Flags().MarkDeprecated("git-paths", "please use --git-path (no ending s) instead")

return cmd
}

Expand Down