This repository was archived by the owner on Nov 1, 2022. It is now read-only.
Move successful chart fetch signal to reconcile #2316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
force-pushed
the
helm/2285-rollback-loop
branch
from
ca1cd95 to
16107a9
Compare
stefanprodan
approved these changes
Aug 1, 2019
As the chart source getter methods are used in other places, e.g. to compare the values checksums, and the condition update causes the `LastUpdateTime` to renew. Given this `LastUpdateTime` timestamp is used to determine if an upgrade should be hold back for rolled back releases, it would corrupt the 'state machine' and give a false positive, causing a infinite loop of rollback-release.
hiddeco
force-pushed
the
helm/2285-rollback-loop
branch
from
16107a9 to
9025aa7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the chart source getter methods are used in other places, e.g.
to compare the values checksums, and the condition update causes
the
LastUpdateTimeto renew.Given this
LastUpdateTimetimestamp is used to determine if anupgrade should be hold back for rolled back releases, it would
corrupt the 'state machine' and give a false positive, causing a
infinite loop of rollback-release.
Fixes #2285