This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Migrate dependency management to Go modules #2083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 23, 2019 16:32
Also, make everything work if `$GOBIN` is defined
|
Close, but no cigar :( kubernetes/kubernetes#67566 |
lolk8s :-( |
|
Huhm, there seems to be a solution https://github.com/golang/go/wiki/Modules#how-can-i-track-tool-dependencies-for-a-module |
2opremio
changed the title
|
The build time goes down to 8.5 minutes since, unlike |
hiddeco
approved these changes
May 24, 2019
|
Great, you can actually stop defining GOPATH altogether |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
$GOBINwork$GOPATHis not required anymore. @hiddeco @squaremo @stefanprodan make sure to move your Flux outside of$GOPATHonce this is merged (the alternative is to prepend every singlegoinvocation byGO111MODULE=onwhich I ended up discarding)