Skip to content
This repository was archived by the owner on Nov 1, 2022. It is now read-only.

Switch to Debian slim as base image #2060

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions docker/Dockerfile.flux
Original file line number Diff line number Diff line change
@@ -1,8 +1,18 @@
FROM alpine:3.9
FROM debian:stable-slim

WORKDIR /home/flux

RUN apk add --no-cache openssh ca-certificates tini 'git>=2.12.0' 'gnutls>=3.6.7' gnupg
RUN echo "deb http://deb.debian.org/debian stretch-backports main" | tee -a /etc/apt/sources.list.d/stretch-backports.list && \
echo "deb http://deb.debian.org/debian testing main" | tee -a /etc/apt/sources.list.d/testing.list && \
apt-get update && \
apt-get install -t stable -y --no-install-recommends \
openssh-client \
ca-certificates \
dirmngr \
gnupg && \
apt-get install -t stretch-backports -y --no-install-recommends git && \
apt-get install -t testing -y --no-install-recommends tini && \
rm -rf /var/lib/apt/lists/*

# Add git hosts to known hosts file so we can use
# StrickHostKeyChecking with git+ssh
Expand All @@ -29,21 +39,12 @@ LABEL maintainer="Weaveworks <[email protected]>" \
org.label-schema.vcs-url="[email protected]:weaveworks/flux" \
org.label-schema.vendor="Weaveworks"

ENTRYPOINT [ "/sbin/tini", "--", "fluxd" ]
ENTRYPOINT [ "tini", "--", "fluxd" ]

# Get the kubeyaml binary (files) and put them on the path
COPY --from=quay.io/squaremo/kubeyaml:0.5.2 /usr/lib/kubeyaml /usr/lib/kubeyaml/
ENV PATH=/bin:/usr/bin:/usr/local/bin:/usr/lib/kubeyaml

# Create minimal nsswitch.conf file to prioritize the usage of /etc/hosts over DNS queries.
# This resolves the conflict between:
# * fluxd using netgo for static compilation. netgo reads nsswitch.conf to mimic glibc,
# defaulting to prioritize DNS queries over /etc/hosts if nsswitch.conf is missing:
# https://github.com/golang/go/issues/22846
# * Alpine not including a nsswitch.conf file. Since Alpine doesn't use glibc
# (it uses musl), maintainers argue that the need of nsswitch.conf is a Go bug:
# https://github.com/gliderlabs/docker-alpine/issues/367#issuecomment-354316460
RUN [ ! -e /etc/nsswitch.conf ] && echo 'hosts: files dns' > /etc/nsswitch.conf
COPY ./kubeconfig /root/.kube/config
COPY ./fluxd /usr/local/bin/

Expand Down
14 changes: 11 additions & 3 deletions docker/Dockerfile.helm-operator
Original file line number Diff line number Diff line change
@@ -1,8 +1,16 @@
FROM alpine:3.9
FROM debian:stable-slim

WORKDIR /home/flux

RUN apk add --no-cache openssh ca-certificates tini 'git>=2.12.0'
RUN echo "deb http://deb.debian.org/debian stretch-backports main" | tee -a /etc/apt/sources.list.d/stretch-backports.list && \
echo "deb http://deb.debian.org/debian testing main" | tee -a /etc/apt/sources.list.d/testing.list && \
apt-get update && \
apt-get install -t stable -y --no-install-recommends \
openssh-client \
ca-certificates && \
apt-get install -t stretch-backports -y --no-install-recommends git && \
apt-get install -t testing -y --no-install-recommends tini && \
rm -rf /var/lib/apt/lists/*

# Add git hosts to known hosts file so we can use
# StrickHostKeyChecking with git+ssh
Expand Down Expand Up @@ -31,7 +39,7 @@ LABEL maintainer="Weaveworks <[email protected]>" \
org.label-schema.vcs-url="[email protected]:weaveworks/flux" \
org.label-schema.vendor="Weaveworks"

ENTRYPOINT [ "/sbin/tini", "--", "helm-operator" ]
ENTRYPOINT [ "tini", "--", "helm-operator" ]

ENV HELM_HOME=/var/fluxd/helm
COPY ./helm-repositories.yaml /var/fluxd/helm/repository/repositories.yaml
Expand Down
2 changes: 1 addition & 1 deletion docker/known_hosts.sh
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ wait=2
until ${ok}; do
generate && validate && ok=true || ok=false
count=$(($count + 1))
if [[ ${count} -eq ${retries} ]]; then
if [ ${count} -eq ${retries} ]; then
echo "ssh-keyscan failed, no more retries left"
exit 1
fi
Expand Down