This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Make it possible to overwrite image TS with label #1992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As this PR changes behaviour (by prioritizing labels over the |
2opremio
reviewed
Apr 30, 2019
2opremio
reviewed
Apr 30, 2019
2opremio
reviewed
Apr 30, 2019
2opremio
approved these changes
Apr 30, 2019
hiddeco
force-pushed
the
bug/891-timestamp-from-labels
branch
from
2743fd0 to
ccf6c52
Compare
|
LGTM |
This adds support for overwriting the image created at timestamp with labels which are set during build. Supported labels (for now) are the Open Container Image (OCI) spec[1] and the (legacy) Label Schema (LS) spec[2]. We prioritize OCI over LS, with a fallback to the CreatedAt. This should serve a wide range of users who either have internal rules for image builds (e.g. timestamp set to null as reported in #1797) or want a stable reliable pointer they can have control over (#746, #891). [1]: https://github.com/opencontainers/image-spec/blob/master/annotations.md#pre-defined-annotation-keys [2]: http://label-schema.org/rc1/#build-time-labels
hiddeco
force-pushed
the
bug/891-timestamp-from-labels
branch
from
ccf6c52 to
0208f1a
Compare
hiddeco
force-pushed
the
bug/891-timestamp-from-labels
branch
from
acd4706 to
a39a860
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for overwriting the image created at timestamp with labels which are set during build. Supported labels (for now) are the Open Container Image (OCI) spec and the (legacy) Label Schema (LS) spec.
We prioritize OCI over LS, with a fallback to the CreatedAt from the registry.
Fixes #891, addresses #1799, #1797, #746