This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Create new ListImagesWithOptions method in v10 #1129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron7
force-pushed
the
listimages-v10
branch
2 times, most recently
from
4020e18 to
8719f7d
Compare
squaremo
suggested changes
Jun 12, 2018
remote/logging.go
Outdated
| func (p *ErrorLoggingServer) ListImagesWithOptions(ctx context.Context, opts v10.ListImagesOptions) (_ []v6.ImageStatus, err error) { | ||
| defer func() { | ||
| if err != nil { | ||
| p.logger.Log("method", "ListImages", "error", err) |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
| "github.com/weaveworks/flux/remote" | ||
| ) | ||
|
|
||
| // RPCClientV10 is the rpc-backed implementation of a server, for |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
remote/rpc/clientV6.go
Outdated
| "github.com/weaveworks/flux/api/v6" | ||
| "github.com/weaveworks/flux/daemon" |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
aaron7
force-pushed
the
listimages-v10
branch
2 times, most recently
from
526391d to
64be046
Compare
squaremo
reviewed
Jun 12, 2018
api/v10/api.go
Outdated
| @@ -0,0 +1,25 @@ | |||
| // This package defines the types for Flux API version 9. | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
squaremo
approved these changes
Jun 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We originally added options to
ListImagesin #1084 however we found out we couldn't make this change because of the RPC method signature.In this PR we revert the
ListImageschange and instead createListImagesWithOptionsin v10. For API versions before v10ListImagesWithOptionswill continue to work, with the WC service polyfilling the container fields filter option.