This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Supply context to image fetch operation #713
Labels
Comments
philwinder
changed the title
|
I don't think this especially needs to be configurable by the user -- it'd be a dial with a rather indirect effect. |
philwinder
added a commit
that referenced
this issue
Aug 24, 2017
- Use WithDeadline rather than WithTimeout - Make deadline configurable Fixes #713
philwinder
added a commit
that referenced
this issue
Aug 24, 2017
- Use WithDeadline rather than WithTimeout - Make deadline configurable Fixes #713
squaremo
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
We want to limit the amount of time we spend on attempting to fetch data for any one image repo, in the interest of fairness. Currently the operation uses a client, created by a factory, which gets a context with a deadline. But it is a better use of
context.Contextto supply the context to the operation, so the caller has the choice of deadline, timeout, or whatever.The text was updated successfully, but these errors were encountered: