Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Automation deploys untagged image #1051

Closed
squaremo opened this issue Apr 23, 2018 · 1 comment
Closed

Automation deploys untagged image #1051

squaremo opened this issue Apr 23, 2018 · 1 comment
Assignees
@squaremo
Labels
bug dogfood ☠ high user impact

Comments

@squaremo
Copy link
Member 

ts=2018-03-24T10:06:59.884426041Z caller=images.go:62 component=sync-loop service=monitoring:deployment/dev-grafana container=grafana currentimage=quay.io/weaveworks/grafana:master-a830190 msg="added image to changes" newimage=quay.io/weaveworks/grafana
@squaremo squaremo self-assigned this Apr 23, 2018
@squaremo squaremo mentioned this issue Apr 23, 2018
Closed
squaremo added a commit that referenced this issue Apr 24, 2018
@squaremo
Log in places we might encounter an untagged image
e31659c 
We don't expect to see untagged images from the image metadata DB, but
we do. To track down #1051, this commit adds some logging to a couple
of places where we would see an empty tag, as well as taking action
when that happens (either aborting the cahe warming op, or skipping
the automated update).
@squaremo squaremo mentioned this issue Apr 24, 2018
Merged
@squaremo
Copy link
Member Author

I believe (based on the evidence of it not happening since) this was fixed in the flurry of PRs culminating in #1251.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@squaremo squaremo

Labels
bug dogfood ☠ high user impact
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@squaremo