Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Commit

Permalink
Switch to Debian slim as base image
Browse files Browse the repository at this point in the history
In versions of Alpine 3.4 and later, a name resolution issue was
introduced and causes problems with certain Kubernetes setups. The
issue appears to be incosistent and difficult to reproduce (but has been
detected on CentOS and NixOS setups). Moving away from Alpine seems the
best option for now.
  • Loading branch information
hiddeco committed May 17, 2019
1 parent 416e842 commit 6911b5b
Show file tree
Hide file tree
Showing 2 changed files with 62 additions and 15 deletions.
44 changes: 32 additions & 12 deletions docker/Dockerfile.flux
Original file line number Diff line number Diff line change
@@ -1,8 +1,37 @@
FROM alpine:3.9
FROM debian:stable-slim

WORKDIR /home/flux

RUN apk add --no-cache openssh ca-certificates tini 'git>=2.12.0' 'gnutls>=3.6.7' gnupg
RUN apt-get update && apt-get install -y --no-install-recommends \
openssh-client \
ca-certificates \
git \
dirmngr \
gnupg \
&& rm -rf /var/lib/apt/lists/*

ENV TINI_VERSION 0.18.0
ENV TINI_GPG_KEY 595E85A6B1B4779EA4DAAEC70B588DFF0527A9B7
ENV GPG_KEY_SERVERS_LIST ha.pool.sks-keyservers.net \
hkp://p80.pool.sks-keyservers.net:80 \
keyserver.ubuntu.com \
hkp://keyserver.ubuntu.com:80 \
pgp.mit.edu

RUN cd /tmp && \
apt-get update && apt-get install -y --no-install-recommends curl && \
export GNUPGHOME="$(mktemp -d)" && \
for server in $(shuf -e $GPG_KEY_SERVERS_LIST); do \
gpg --keyserver "$server" --recv-keys $TINI_GPG_KEY && break || : ; \
done && \
gpg --fingerprint $TINI_GPG_KEY | grep -q "6380 DC42 8747 F6C3 93FE ACA5 9A84 159D 7001 A4E5" && \
curl -sSL "https://github.com/krallin/tini/releases/download/v${TINI_VERSION}/tini_${TINI_VERSION}.deb" -o tini.deb && \
curl -sSL "https://github.com/krallin/tini/releases/download/v${TINI_VERSION}/tini_${TINI_VERSION}.deb.asc" -o tini.deb.asc && \
gpg --verify tini.deb.asc tini.deb && \
apt-get install /tmp/tini.deb && \
apt-get purge --auto-remove -y curl && \
rm -r "$GNUPGHOME" tini.deb* && \
rm -rf /var/lib/apt/lists/*

# Add git hosts to known hosts file so we can use
# StrickHostKeyChecking with git+ssh
Expand All @@ -29,21 +58,12 @@ LABEL maintainer="Weaveworks <[email protected]>" \
org.label-schema.vcs-url="[email protected]:weaveworks/flux" \
org.label-schema.vendor="Weaveworks"

ENTRYPOINT [ "/sbin/tini", "--", "fluxd" ]
ENTRYPOINT [ "tini", "--", "fluxd" ]

# Get the kubeyaml binary (files) and put them on the path
COPY --from=quay.io/squaremo/kubeyaml:0.5.2 /usr/lib/kubeyaml /usr/lib/kubeyaml/
ENV PATH=/bin:/usr/bin:/usr/local/bin:/usr/lib/kubeyaml

# Create minimal nsswitch.conf file to prioritize the usage of /etc/hosts over DNS queries.
# This resolves the conflict between:
# * fluxd using netgo for static compilation. netgo reads nsswitch.conf to mimic glibc,
# defaulting to prioritize DNS queries over /etc/hosts if nsswitch.conf is missing:
# https://github.com/golang/go/issues/22846
# * Alpine not including a nsswitch.conf file. Since Alpine doesn't use glibc
# (it uses musl), maintainers argue that the need of nsswitch.conf is a Go bug:
# https://github.com/gliderlabs/docker-alpine/issues/367#issuecomment-354316460
RUN [ ! -e /etc/nsswitch.conf ] && echo 'hosts: files dns' > /etc/nsswitch.conf
COPY ./kubeconfig /root/.kube/config
COPY ./fluxd /usr/local/bin/

Expand Down
33 changes: 30 additions & 3 deletions docker/Dockerfile.helm-operator
Original file line number Diff line number Diff line change
@@ -1,8 +1,35 @@
FROM alpine:3.9
FROM debian:stable-slim

WORKDIR /home/flux

RUN apk add --no-cache openssh ca-certificates tini 'git>=2.12.0'
RUN apt-get update && apt-get install -y --no-install-recommends \
openssh-client \
ca-certificates \
git \
&& rm -rf /var/lib/apt/lists/*

ENV TINI_VERSION 0.18.0
ENV TINI_GPG_KEY 595E85A6B1B4779EA4DAAEC70B588DFF0527A9B7
ENV GPG_KEY_SERVERS_LIST ha.pool.sks-keyservers.net \
hkp://p80.pool.sks-keyservers.net:80 \
keyserver.ubuntu.com \
hkp://keyserver.ubuntu.com:80 \
pgp.mit.edu

RUN cd /tmp && \
apt-get update && apt-get install -y curl gnupg && \
export GNUPGHOME="$(mktemp -d)" && \
for server in $(shuf -e $GPG_KEY_SERVERS_LIST); do \
gpg --keyserver "$server" --recv-keys $TINI_GPG_KEY && break || : ; \
done && \
gpg --fingerprint $TINI_GPG_KEY | grep -q "6380 DC42 8747 F6C3 93FE ACA5 9A84 159D 7001 A4E5" && \
curl -sSL "https://github.com/krallin/tini/releases/download/v${TINI_VERSION}/tini_${TINI_VERSION}.deb" -o tini.deb && \
curl -sSL "https://github.com/krallin/tini/releases/download/v${TINI_VERSION}/tini_${TINI_VERSION}.deb.asc" -o tini.deb.asc && \
gpg --verify tini.deb.asc tini.deb && \
apt-get install /tmp/tini.deb && \
apt-get purge --auto-remove -y curl gnupg && \
rm -r "$GNUPGHOME" tini.deb* && \
rm -rf /var/lib/apt/lists/*

# Add git hosts to known hosts file so we can use
# StrickHostKeyChecking with git+ssh
Expand Down Expand Up @@ -31,7 +58,7 @@ LABEL maintainer="Weaveworks <[email protected]>" \
org.label-schema.vcs-url="[email protected]:weaveworks/flux" \
org.label-schema.vendor="Weaveworks"

ENTRYPOINT [ "/sbin/tini", "--", "helm-operator" ]
ENTRYPOINT [ "tini", "--", "helm-operator" ]

ENV HELM_HOME=/var/fluxd/helm
COPY ./helm-repositories.yaml /var/fluxd/helm/repository/repositories.yaml
Expand Down

0 comments on commit 6911b5b

Please sign in to comment.