This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Clarify which fields of cache.Warmer are required
The cache.Warmer struct has some mandatory fields and some optional. With a constructor we can better enforce this. In particular, the cache client implementation, which is now mandatory but was still described as optional in examples and help text. We can simplify (and in examples, omit) the default values by assuming memcached is in the same namespace.
- Loading branch information
Showing
5 changed files
with
69 additions
and
71 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -32,20 +32,17 @@ spec: | |
- name: git-key | ||
mountPath: /etc/fluxd/ssh | ||
args: | ||
# if you deployed memcached, you can supply these arguments to | ||
# tell fluxd to use it. You may need to change the namespace | ||
# (`default`) if you run fluxd in another namespace. | ||
- --memcached-hostname=memcached.default.svc.cluster.local | ||
- --memcached-timeout=100ms | ||
- --memcached-service=memcached | ||
- --registry-cache-expiry=20m | ||
|
||
# if you deployed memcached in a different namespace to flux, | ||
# or with a different service name, you can supply these | ||
# following two arguments to tell fluxd how to connect to it. | ||
# - --memcached-hostname=memcached.default.svc.cluster.local | ||
# - --memcached-service=memcached | ||
|
||
# replace (at least) the following URL | ||
- [email protected]:weaveworks/flux-example | ||
- --git-branch=master | ||
# include these next two to connect to an "upstream" service | ||
# (e.g., Weave Cloud). The token is particular to the service. | ||
# - --connect=wss://cloud.weave.works/api/flux | ||
# - --token=abc123abc123abc123abc123 | ||
# override -b and -t arguments to ssh-keygen | ||
# - --ssh-keygen-bits=2048 | ||
- --ssh-keygen-type=ed25519 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters