Gloo: Create gloo upstreams from non-discovered services

[saiskee]

Signed-off-by: Keerthan Ekbote [email protected]

[stefanprodan]

@saiskee please run make fmt and commit the changes to unblock CI.

[stefanprodan]

CI is failing with:

--- FAIL: TestGlooRouter_Sync (0.01s)
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x1d01fe0]

[snuggie12]

Perhaps this should be a separate issue/PR, but this only fixes our non-istio upstreams.

To solve that I think you'd need in your Canary something like upstreamSslConfigSpec

[stefanprodan]

@saiskee this again:

please run make fmt and commit the changes to unblock CI.

[stefanprodan]

@saiskee now the unit tests are failing, can you please run make test before pushing any more changes? Thanks

--- FAIL: TestGlooRouter_Sync (0.00s)
    gloo_test.go:42: 
        	Error Trace:	gloo_test.go:42
        	Error:      	Received unexpected error:
        	            	error creating flagger primary upstream: service podinfo-primary.default get query error: services "podinfo-primary" not found
        	Test:       	TestGlooRouter_Sync
--- FAIL: TestGlooRouter_SetRoutes (0.00s)
    gloo_test.go:82: 
        	Error Trace:	gloo_test.go:82
        	Error:      	Received unexpected error:
        	            	error creating flagger primary upstream: service podinfo-primary.default get query error: services "podinfo-primary" not found
        	Test:       	TestGlooRouter_SetRoutes
--- FAIL: TestGlooRouter_GetRoutes (0.00s)
    gloo_test.go:144: 
        	Error Trace:	gloo_test.go:144
        	Error:      	Received unexpected error:
        	            	error creating flagger primary upstream: service podinfo-primary.default get query error: services "podinfo-primary" not found
        	Test:       	TestGlooRouter_GetRoutes

[codecov-commenter]

Codecov Report

Merging #894 (fdc8dd8) into main (c9257bd) will increase coverage by 0.15%.
The diff coverage is 81.48%.

@@            Coverage Diff             @@
##             main     #894      +/-   ##
==========================================
+ Coverage   56.64%   56.80%   +0.15%     
==========================================
  Files          69       69              
  Lines        5665     5704      +39     
==========================================
+ Hits         3209     3240      +31     
- Misses       1978     1981       +3     
- Partials      478      483       +5     

Impacted Files	Coverage Δ
pkg/metrics/observers/gloo.go	46.66% <ø> (ø)
pkg/router/factory.go	0.00% <0.00%> (ø)
pkg/router/gloo.go	80.52% <85.71%> (-1.11%)	⬇️
pkg/canary/config_tracker.go	83.25% <0.00%> (-0.91%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9257bd...fdc8dd8. Read the comment docs.

[stefanprodan]

@saiskee please update the Helm docs to tell people that discovery is no longer required: https://github.com/fluxcd/flagger/blob/main/charts/flagger/README.md

This also needs an update: https://github.com/fluxcd/flagger/blob/main/docs/gitbook/tutorials/gloo-progressive-delivery.md#bootstrap

# applied 
deployment.apps/podinfo
horizontalpodautoscaler.autoscaling/podinfo
virtualservices.gateway.solo.io/podinfo
canary.flagger.app/podinfo

# generated 
deployment.apps/podinfo-primary
horizontalpodautoscaler.autoscaling/podinfo-primary
service/podinfo
service/podinfo-canary
service/podinfo-primary
routetables.gateway.solo.io/podinfo

[stefanprodan]

LGTM

Thanks @saiskee 🏅