-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add alerting http proxy option #872
Add alerting http proxy option #872
Conversation
c2c6407
to
acd0006
Compare
Codecov Report
@@ Coverage Diff @@
## main #872 +/- ##
==========================================
- Coverage 56.68% 56.58% -0.11%
==========================================
Files 67 67
Lines 5439 5463 +24
==========================================
+ Hits 3083 3091 +8
- Misses 1896 1910 +14
- Partials 460 462 +2
Continue to review full report at Codecov.
|
@L3o-pold thank you for this! Can you confirm that this works with and without the proxy setting? Have you tested it with Slack or MS Teams? |
acd0006
to
f639ff9
Compare
Signed-off-by: Léopold Jacquot <[email protected]>
f639ff9
to
b82fd5e
Compare
@stefanprodan I tested with and without proxy setting with Slack provider. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @L3o-pold 🏅
bug introduced by fluxcd#872 Signed-off-by: Léopold Jacquot <[email protected]>
bug introduced by fluxcd#872 Signed-off-by: Léopold Jacquot <[email protected]>
Fix #871