Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alerting http proxy option #872

Merged
merged 1 commit into from
Apr 28, 2021

Conversation

L3o-pold
Copy link
Contributor

@L3o-pold L3o-pold commented Apr 1, 2021

Fix #871

@L3o-pold L3o-pold requested a review from stefanprodan as a code owner April 1, 2021 09:01
@L3o-pold L3o-pold force-pushed the feature/add-alerting-http-proxy branch 2 times, most recently from c2c6407 to acd0006 Compare April 1, 2021 09:14
@codecov-io
Copy link

Codecov Report

Merging #872 (c2c6407) into main (cb24c74) will decrease coverage by 0.10%.
The diff coverage is 37.14%.

❗ Current head c2c6407 differs from pull request most recent head acd0006. Consider uploading reports for the commit acd0006 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #872      +/-   ##
==========================================
- Coverage   56.68%   56.58%   -0.11%     
==========================================
  Files          67       67              
  Lines        5439     5463      +24     
==========================================
+ Hits         3083     3091       +8     
- Misses       1896     1910      +14     
- Partials      460      462       +2     
Impacted Files Coverage Δ
pkg/notifier/factory.go 0.00% <0.00%> (ø)
pkg/notifier/client.go 31.42% <11.76%> (-21.21%) ⬇️
pkg/controller/events.go 55.65% <50.00%> (-0.60%) ⬇️
pkg/notifier/discord.go 72.22% <100.00%> (+0.79%) ⬆️
pkg/notifier/rocket.go 75.75% <100.00%> (+0.75%) ⬆️
pkg/notifier/slack.go 75.75% <100.00%> (+0.75%) ⬆️
pkg/notifier/teams.go 76.92% <100.00%> (+0.92%) ⬆️
pkg/canary/config_tracker.go 84.16% <0.00%> (+0.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb24c74...acd0006. Read the comment docs.

@stefanprodan
Copy link
Member

@L3o-pold thank you for this! Can you confirm that this works with and without the proxy setting? Have you tested it with Slack or MS Teams?

@L3o-pold L3o-pold force-pushed the feature/add-alerting-http-proxy branch from acd0006 to f639ff9 Compare April 8, 2021 09:56
Signed-off-by: Léopold Jacquot <[email protected]>
@L3o-pold L3o-pold force-pushed the feature/add-alerting-http-proxy branch from f639ff9 to b82fd5e Compare April 8, 2021 09:58
@L3o-pold
Copy link
Contributor Author

L3o-pold commented Apr 8, 2021

@stefanprodan I tested with and without proxy setting with Slack provider.

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @L3o-pold 🏅

@stefanprodan stefanprodan merged commit d596638 into fluxcd:main Apr 28, 2021
L3o-pold added a commit to L3o-pold/flagger that referenced this pull request Jun 24, 2021
bug introduced by fluxcd#872

Signed-off-by: Léopold Jacquot <[email protected]>
L3o-pold added a commit to L3o-pold/flagger that referenced this pull request Jun 24, 2021
bug introduced by fluxcd#872

Signed-off-by: Léopold Jacquot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support proxy for Alerting
3 participants