Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chart: Add pull secret for Prometheus deployment #842

Merged
merged 1 commit into from
Mar 5, 2021

Conversation

Lapeyus
Copy link
Contributor

@Lapeyus Lapeyus commented Mar 5, 2021

Prometheus deployment created by the Helm chart is missing a pull secret,
variable is necessary to pull the prometheus image from private a repository

fix: #841

@Lapeyus Lapeyus requested a review from stefanprodan as a code owner March 5, 2021 00:40
Prometheus deployment created by the Helm chart is missing a pull secret,
variable is necessary to pull the prometheus image from private a repository

Signed-off-by: Joseph Villarreal Lopez <[email protected]>
@Lapeyus Lapeyus force-pushed the missing-helm-variable branch from 1914c5d to 73c4833 Compare March 5, 2021 00:49
@Lapeyus
Copy link
Contributor Author

Lapeyus commented Mar 5, 2021

PR Closes #841

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefanprodan stefanprodan changed the title Add missing pull secret on Prometheus deployment chart: Add pull secret for Prometheus deployment Mar 5, 2021
@stefanprodan stefanprodan merged commit 9112c5a into fluxcd:main Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing pull secret on Prometheus deployment
2 participants