-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Istio k8s client #80
Conversation
CORS and RetryOn are missing from the knative pkg. Until Istio has an official k8s client, we'll maintain our own.
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
==========================================
+ Coverage 54.53% 54.56% +0.03%
==========================================
Files 13 13
Lines 1533 1532 -1
==========================================
Hits 836 836
+ Misses 557 556 -1
Partials 140 140
Continue to review full report at Codecov.
|
@@ -0,0 +1,19 @@ | |||
package v1alpha1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did this get generated or you did this by hand? this is for my learning 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All was done by hand :(
👍 This is nice. I assume this will solve our problem with CORS policy(#58) that is unsupported currently in the CanaryService object as well ? |
Yes this will allow us to ship CORS support. What's more important is that we can now control the upgrade path to Istio 1.1 without depending on some other project that could chose to delay the upgrade for months. |
This PR replaces the knative pkg with an Istio client generated based on the v1.1.0 protos. Only the Virtual Service CRD is implemented from the
networking/v1alpha3
group.Fix: #79