Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(grafana): metrics change since 1.16 #667

Merged
merged 1 commit into from
Aug 12, 2020
Merged

Conversation

snahelou
Copy link
Contributor

Hello

With Kubernetes 1.16, some metrics have been changed in cadvisor and istio :( :

Feel free to merge it if you want to have a working dashboard with k8s 1.16 (tested on GKE +Istio from my side)

BR

@snahelou snahelou requested a review from stefanprodan as a code owner August 11, 2020 09:17
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @snahelou 🥇

@stefanprodan stefanprodan merged commit 34f0273 into fluxcd:master Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants