Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add priorityClassName to flagger and loadtester chart #652

Merged
merged 3 commits into from
Jul 27, 2020
Merged

Add priorityClassName to flagger and loadtester chart #652

merged 3 commits into from
Jul 27, 2020

Conversation

imrenagi
Copy link
Contributor

Changes:

  • Add podPriorityClassName to values.yaml
  • Add optional priorityClassName field to deployment

These applies for flagger and loadtester charts.

Solve #645

@imrenagi imrenagi requested a review from stefanprodan as a code owner July 23, 2020 00:36
@stefanprodan
Copy link
Member

@imrenagi can you please add the podPriorityClassName to each chart readme in the options table?

@imrenagi
Copy link
Contributor Author

sure. will add it later today. thanks!

@imrenagi
Copy link
Contributor Author

@stefanprodan please recheck. I've updated the readme. Thanks!

stefanprodan
stefanprodan approved these changes Jul 23, 2020
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @imrenagi

@stefanprodan stefanprodan merged commit fa9de7d into fluxcd:master Jul 27, 2020
@imrenagi imrenagi deleted the feature/pod-priority branch August 7, 2020 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imrenagi @stefanprodan