Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check metrics server availability during canary initialization #592

Merged
merged 4 commits into from
May 16, 2020

Conversation

mathetake
Copy link
Collaborator

@mathetake mathetake commented May 15, 2020

resolves #554


TODO in this PR:

  • write uni test for checkMetricProviderAvailability

@mathetake mathetake requested a review from stefanprodan as a code owner May 15, 2020 10:37
@mathetake mathetake changed the title Check metrics server availability Check metrics server availability during canary initialization May 15, 2020
@codecov-io
Copy link

codecov-io commented May 15, 2020

Codecov Report

Merging #592 into master will decrease coverage by 0.02%.
The diff coverage is 48.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #592      +/-   ##
==========================================
- Coverage   54.95%   54.92%   -0.03%     
==========================================
  Files          62       62              
  Lines        5241     5278      +37     
==========================================
+ Hits         2880     2899      +19     
- Misses       1944     1956      +12     
- Partials      417      423       +6     
Impacted Files Coverage Δ
pkg/metrics/providers/prometheus.go 69.69% <ø> (+2.04%) ⬆️
pkg/controller/scheduler.go 44.67% <33.33%> (-0.08%) ⬇️
pkg/controller/scheduler_metrics.go 34.18% <50.00%> (+3.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b0c49b...e0de9d0. Read the comment docs.

@mathetake
Copy link
Collaborator Author

will work on unit test tomorrow

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@mathetake mathetake merged commit 0056b99 into master May 16, 2020
@mathetake mathetake deleted the check-metrics-server-availability branch May 16, 2020 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

invoke IsOnline method during canary resource initialization
3 participants