Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/canary: fix status retry #541

Merged
merged 1 commit into from
Apr 1, 2020
Merged

pkg/canary: fix status retry #541

merged 1 commit into from
Apr 1, 2020

Conversation

stefanprodan
Copy link
Member

The status retry logic was disabled in 8e9b9a3 this PR restores the intended behaviour.

@stefanprodan stefanprodan requested a review from mathetake April 1, 2020 10:42
mathetake
mathetake approved these changes Apr 1, 2020
View reviewed changes
Copy link
Collaborator

@mathetake mathetake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you so much @stefanprodan 🥇

@stefanprodan stefanprodan merged commit 7c00e5b into master Apr 1, 2020
@stefanprodan stefanprodan deleted the retry-fixes branch April 1, 2020 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathetake mathetake mathetake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanprodan @mathetake