Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor virtual service sync #54

Merged
merged 2 commits into from
Feb 24, 2019
Merged

Refactor virtual service sync #54

merged 2 commits into from
Feb 24, 2019

Conversation

stefanprodan
Copy link
Member

@stefanprodan stefanprodan commented Feb 24, 2019

  • detect changes in virtual service with cmp
  • ignore destination weight when comparing the two specs
  • add tests for virtual service insert, update and config drift

Followup of #51

- ignore destination weight when comparing the two specs
@codecov-io
Copy link

Codecov Report

Merging #54 into master will increase coverage by 0.35%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
+ Coverage   56.34%   56.69%   +0.35%     
==========================================
  Files           9        9              
  Lines        1340     1344       +4     
==========================================
+ Hits          755      762       +7     
+ Misses        452      448       -4     
- Partials      133      134       +1
Impacted Files Coverage Δ
pkg/controller/router.go 84.95% <75%> (+1.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbbabdf...1dc7677. Read the comment docs.

@stefanprodan stefanprodan merged commit c835892 into master Feb 24, 2019
@stefanprodan stefanprodan deleted the vsvc branch February 24, 2019 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants