-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add prometheus-operator tutorial #524
Conversation
Codecov Report
@@ Coverage Diff @@
## master #524 +/- ##
=======================================
Coverage 50.29% 50.29%
=======================================
Files 63 63
Lines 4939 4939
=======================================
Hits 2484 2484
Misses 2044 2044
Partials 411 411 Continue to review full report at Codecov.
|
@Wihrt is this PR ready for review? I see NGINX references and the last sentence doesn't look finished. |
iterations: 10 | ||
threshold: 2 | ||
metrics: | ||
# For some reason, you need to not use a standard name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason is that the standard names are reserved for the builtin metrics, please change this.
provider: | ||
address: http://prometheus-prometheus-oper-prometheus.prometheus:9090 | ||
type: prometheus | ||
query: rate(http_requests_total{namespace="{{ namespace }}",job="{{ target }}-canary",status!~"5.*"}[{{ interval }}]) / rate(http_requests_total{namespace="{{ namespace }}",job="{{ target }}-canary"}[{{ interval }}]) * 100 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please format this so it's readable, there are many examples in the docs if you want to see how it should look.
helm repo add stable https://kubernetes-charts.storage.googleapis.com | ||
helm repo update | ||
kubectl create ns prometheus | ||
helm upgrade -i prometheus stable/prometheus-operator \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use fullnameOverride and set the namespace to monitoring
so that the URL will look better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @Wihrt I'll include the tutorial in the docs site on the next Flagger release
Add documentation for flagger with prometheus-operator