Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement canary service target port #327

Merged
merged 17 commits into from
Oct 8, 2019
Merged

Implement canary service target port #327

merged 17 commits into from
Oct 8, 2019

Conversation

stefanprodan
Copy link
Member

@stefanprodan stefanprodan commented Oct 6, 2019

This PR adds the service.targetPort to the canary CRD. The target port can be specified using the container port number or port name.

Example:

apiVersion: flagger.app/v1alpha3
kind: Canary
metadata:
  name: podinfo
spec:
  service:
    # ClusterIP port number
    port: 80
    # ClusterIP port name can be http or grpc (default http)
    portName: http
    # container port number or name
    targetPort: 9898
    # add all the other container ports
    # when generating ClusterIP services (default false)
    portDiscovery: true

Automated end-to-end tests coverage:

  • Kubernetes CNI target port number
  • Kubernetes CNI target port name
  • Istio target port number
  • Istio target port name
  • Linkerd target port number
  • Linkerd target port name
  • NGINX target port number
  • NGINX target port name
  • Gloo target port number
  • Gloo target port name

Fix: #279
Fix: #328

@stefanprodan stefanprodan force-pushed the target-port branch 3 times, most recently from 1b44e51 to 0107296 Compare October 6, 2019 19:35
Update Gloo to v0.20.2
Enable Gloo discovery Fix: #328
@stefanprodan stefanprodan merged commit 61ab596 into master Oct 8, 2019
@stefanprodan stefanprodan deleted the target-port branch October 8, 2019 08:10
This was referenced Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gloo upstream group not working with discovery disabled Different service target port
1 participant