-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement helm and bash pre-rollout hooks #196
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be used as pre-rollout hook
To be deployed in kube-system namespace, uses tiller service account
stefanprodan
changed the title
Implement helm test pre-rollout hook
Implement bash and helm pre-rollout hook
Jun 4, 2019
stefanprodan
changed the title
Implement bash and helm pre-rollout hook
Implement bash and helm pre-rollout hooks
Jun 4, 2019
stefanprodan
force-pushed
the
helm-test-hook
branch
from
June 4, 2019 11:57
a6104bf
to
62a5f8c
Compare
stefanprodan
changed the title
Implement bash and helm pre-rollout hooks
Implement helm and bash pre-rollout hooks
Jun 4, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two blocking commands to Flagger's test runner:
type: helm
intended for running helm teststype: bash
intended for running bats testsUsage
Deploy the helm test runner in the
kube-system
namespace using thetiller
service account:Run helm and bats tests before the canary starts receiving traffic:
Note that you should create a ConfigMap with your bats tests and mount it inside the tester container.