fix reconcilePrimaryHpa doesn't fall back to v2beta2 #1238
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So the problems is I'm using flagger 1.22 on a 1.19 eks. which doesn't has hpa v2, but has hpa v2beta2.
from the
falling back to v2beta2
log and lattercreating HorizontalPodAutoscaler v2
log. we can tell that it's not going to the expected if branch. which I think it's due to failed hpa query while has error, still return something for hpa.log:
I tested on my 1.19 eks. works fine.