[docs] update promql query for istio request duration #1018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A minor issue I stumbled across while learning how to drive Flagger, is that the docs still use `istio_request_duration_seconds_bucket` to illustrate the query behind the `request-duration` metric. I understand that this changed with Istio 1.5 (fluxcd#478), but it seems that in the current version of flagger, the correct metric must already be used, since I'm getting duration metrics out of Istio 1.10 :) This change simply makes the docs clearer for those of us trying to understand exactly what `request-duration` entails! Signed-off-by: David Young <[email protected]>
funkypenguin
force-pushed
the
patch-1
branch
from
9eefe49 to
a2b58d5
Compare
Codecov Report
@@ Coverage Diff @@
## main #1018 +/- ##
==========================================
- Coverage 56.95% 56.91% -0.04%
==========================================
Files 76 76
Lines 6093 6093
==========================================
- Hits 3470 3468 -2
- Misses 2098 2100 +2
Partials 525 525
Continue to review full report at Codecov.
|
stefanprodan
approved these changes
Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A minor issue I stumbled across while learning how to drive Flagger, is that the docs still use
istio_request_duration_seconds_bucketto illustrate the query behind therequest-durationmetric. I understand that this changed with Istio 1.5 (#478), but it seems that in the current version of flagger, the correct metric must already be used, since I'm getting duration metrics out of Istio 1.10 :)This change simply makes the docs clearer for those of us trying to understand exactly what
request-durationentails!