Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canary service trafficPolicy loadBalancer localityLbSetting is not generated config in dr? #997

Closed
13567436138 opened this issue Aug 31, 2021 · 1 comment · Fixed by #1016

Comments

@13567436138
Copy link

Describe the bug

A clear and concise description of what the bug is.
Please provide the Canary definition and Flagger logs.

To Reproduce

apply config:

apiVersion: flagger.app/v1beta1
kind: Canary
metadata:
  name: bookinfo
spec:
  revertOnDeletion: true
  targetRef:
    apiVersion: apps/v1
    kind: Deployment
    name: reviews-v1
  provider: istio
  service:
    port: 9080
    name: reviews
    trafficPolicy:
      loadBalancer:
        simple: LEAST_CONN
        localityLbSetting:
          enabled: true
          failover:
          - from: us-central1
            to: us-central2
          - from: us-central2
            to: us-central1
      outlierDetection:
        consecutive5xxErrors: 1
        interval: 5m
        baseEjectionTime: 15m
    gateways:
    - istio/bookinfo-gateway
    hosts:
    - "*"
  analysis:
    interval: 1m
    threshold: 10
    maxWeight: 50
    stepWeight: 20
    metrics:
      - name: request-success-rate
        thresholdRange:
          min: 99
        interval: 1m
      - name: request-duration
        thresholdRange:
          max: 500
        interval: 1m

generated config:

spec:
  host: reviews-primary
  trafficPolicy:
    loadBalancer:
      simple: LEAST_CONN
    outlierDetection:
      baseEjectionTime: 15m
      consecutive5xxErrors: 1
      interval: 5m

Expected behavior

A clear and concise description of what you expected to happen.

Additional context

  • Flagger version:
  • Kubernetes version:
  • Service Mesh provider: istio
  • Ingress provider:
@stefanprodan
Copy link
Member

Same issue as here: #996 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants