Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

canary service trafficPolicy loadBalancer consistentHash generate dr not right #996

Closed
13567436138 opened this issue Aug 31, 2021 · 2 comments · Fixed by #1016
Closed

canary service trafficPolicy loadBalancer consistentHash generate dr not right #996

13567436138 opened this issue Aug 31, 2021 · 2 comments · Fixed by #1016

Comments

@13567436138
Copy link

Describe the bug

A clear and concise description of what the bug is.
Please provide the Canary definition and Flagger logs.

To Reproduce

apply config:

apiVersion: flagger.app/v1beta1
kind: Canary
metadata:
  name: bookinfo
spec:
  revertOnDeletion: true
  targetRef:
    apiVersion: apps/v1
    kind: Deployment
    name: reviews-v1
  provider: istio
  service:
    port: 9080
    name: reviews
    trafficPolicy:
      loadBalancer:
        consistentHash:
          minimumRingSize: 1
          httpQueryParameterName: test
    gateways:
    - istio/bookinfo-gateway
    hosts:
    - "*"
  analysis:
    interval: 1m
    threshold: 10
    maxWeight: 50
    stepWeight: 20
    metrics:
      - name: request-success-rate
        thresholdRange:
          min: 99
        interval: 1m
      - name: request-duration
        thresholdRange:
          max: 500
        interval: 1m

generate config is:

spec:
  host: reviews-canary
  trafficPolicy:
    loadBalancer:
      consistentHash:
        minimumRingSize: 1

httpQueryParameterName: test is missing???

Expected behavior

A clear and concise description of what you expected to happen.

Additional context

  • Flagger version:
  • Kubernetes version:
  • Service Mesh provider:
  • Ingress provider:
@stefanprodan
Copy link
Member

The Istio API needs to be sync with upstream, here is the current version that Flagger uses: https://github.com/fluxcd/flagger/blob/main/pkg/apis/istio/v1alpha3/destination_rule.go#L279

@13567436138
Copy link
Author

when will flagger support istio v1beta1
why not let flagger generate istio resources use v1alpha3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants