configure: relax flux-security version check #6673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yay! Thanks! |
Problem: Tests in the testsuite may need to check for a minimum flux-security version, but there's no helper to do that. Add test_flux_security_version() to sharness.d/flux-sharness.sh that checks for a minimum flux-security verison if flux is configured with flux-security.
Problem: The sdexec module launches work as systemd transient units with Type=notify, which implies flux-security >= 0.14.0 is being used at runtime. However, we don't want to make this version of flux-security a hard requirement at this time. Add a runtime version check to the sdexec module and exit with an error if an incompatible flux-security version is found.
Problem: Tests that load the sdexec module require flux-security v0.14.0 or later, but this is not checked. Add checks to the sdexec tests for the correct flux-security version.
Problem: configure currently requires flux-security v0.14.0 or later, but this is only required for the sdexec module, only used in system instances and a few tests. Now that the sdexec module and tests have runtime checks for the flux-security version, relax the required version of flux-security back to v0.13.0. Note that v0.14.0 is still installed in CI and required in the debian control file.
grondo
force-pushed
the
downgrade-flux-security
branch
from
84375af to
8d61172
Compare
|
@Mergifyio requeue |
❌ This pull request head commit has not been previously disembarked from queue. |
|
@Mergifyio refresh |
✅ Pull request refreshed |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6673 +/- ##
=======================================
Coverage 83.85% 83.86%
=======================================
Files 533 533
Lines 88686 88695 +9
=======================================
+ Hits 74369 74381 +12
+ Misses 14317 14314 -3
|
|
Oh duh, I should have anticipated that problem, sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relaxes the flux-security version check from v0.14.0 back to v0.13.0 since v0.14.0 is only required for the sdexec module when used to launch jobs in a system instance.
A test is added to the sdexec module to abort if a sufficient flux-security version isn't found at runtime, and a version check added to affected tests.
This allows flux-core to continue to be built on TOSS systems with flux-security v0.13.0 installed. We'll probably have to run with this version for a month at least, and it is nice to be able to build test versions of flux
--with-flux-security.Fixes #6672