flux-hostlist: add -F, --find=HOSTS option
#6671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: Other hostlist commands have a `-F, --find` option, but flux-hostlist(1) does not. Also, there is not another good way to determine the index of the current host in a hostlist. Add a `-F, --find=HOSTS` option to flux-hostlist which takes a hostlist and returns a space-separated list of indices of each host in the target hostlist.
Problem: There are no tests of `flux hostlist -F, --find`. Add some to t2814-hostlist-cmd.t.
Problem: The `-F, --find=HOSTS` option for flux-hostlist is not documented. Document it in flux-hostlist(1).
grondo
force-pushed
the
hostlist-find
branch
from
1106c62 to
520eae5
Compare
|
Thanks! I'll set MWP. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6671 +/- ##
==========================================
- Coverage 83.86% 83.84% -0.03%
==========================================
Files 533 533
Lines 88683 88686 +3
==========================================
- Hits 74375 74358 -17
- Misses 14308 14328 +20
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simply adds a
-F, --find=HOSTSoption toflux hostlist, which allows getting the index of one or more hosts in the target hostlist.