-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(share_plus): #1299 document XFile.fromData #1300
Conversation
Document the use of temporary directories and why developers should care about it.
@Coronon fyi |
@miquelbeltran Thanks for adding this so quickly :) Just don’t merge yet, you wrote |
Thanks! fixed it and added a link to path_provider as well |
Fabulous 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one typo and one possible dot at the end of a sentence - if you like 😊
Co-authored-by: Joachim Nohl <[email protected]>
Co-authored-by: Joachim Nohl <[email protected]>
Thank you @nohli ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
It seems that the whole Known issues
section is missing from our website docs.
Description
Document the use of temporary directories and why developers should care about it.
Related Issues
Checklist
CHANGELOG.md
nor thepubspec.yaml
files.flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!
in the title as explained in Conventional Commits).