Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(template): wrong attribute to remove alpha channel #586

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(template): wrong attribute to remove alpha channel #586

wants to merge 2 commits into from

Conversation

chungxon
Copy link
Contributor

This PR fixes the template after running the command to create a new config automatically:

  • Replaced the remove_alpha_channel_ios attribute with remove_alpha_ios
  • Added missing attributes adaptive_icon_foreground_inset and background_color_ios
  • Removed duplicated lines on the readme file

MarkOSullivan94
MarkOSullivan94 reviewed Sep 28, 2024
View reviewed changes
README.md
@@ -96,7 +96,6 @@ Shown below is the full list of attributes which you can specify within your Flu
- `true`: Override the default existing Flutter launcher icon for the platform specified
- `false`: Ignore making launcher icons for this platform
- `icon/path/here.png`: This will generate a new launcher icons for the platform with the name you specify, without removing the old default existing Flutter launcher icon.
- `image_path`: The location of the icon image file which you want to use as the app launcher icon
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still used

Please undo this removal

Copy link
Contributor Author

@chungxon chungxon Sep 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarkOSullivan94 I think this is a duplicate of the line that already exists in the global section, which confuses me. Also, this line is currently missing from the IOS tutorial section. Is that right, or is this line missing from IOS too? If not, I will revert the change. Thanks!

image

@phamquoctrongdev
Copy link

remove_alpha_channel_ios or remove_alpha_ios is true?
Why the official document only mention remove_alpha_ios parameter?
Sorry for my bad English.

@chungxon
Copy link
Contributor Author

remove_alpha_channel_ios or remove_alpha_ios is true? Why the official document only mention remove_alpha_ios parameter? Sorry for my bad English.

@phamquoctrongdev remove_alpha_ios is correct, it is also mentioned in the official documentation.

remove_alpha_channel_ios may be outdated, I couldn't find it in the source code. But it is still there in the config file when you run to auto-generate the config file from the command dart run flutter_launcher_icons:generate. That is what I updated in this PR

This PR fixes the template after running the command to create a new config automatically:

  • Replaced the remove_alpha_channel_ios attribute with remove_alpha_ios
  • Added missing attributes adaptive_icon_foreground_inset and background_color_ios

@chungxon
Copy link
Contributor Author

Hey @MarkOSullivan94 Can you take a look at this PR? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkOSullivan94 MarkOSullivan94 Awaiting requested review from MarkOSullivan94

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chungxon @phamquoctrongdev @MarkOSullivan94