Fix remove alpha for iOS #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcsvcn
approved these changes
Mar 9, 2023
|
I tested and it is working! Thanks @mike-500 |
|
Hey @RatakondalaArun, @bradintheusa, can you please take a look? 🙏🏼 |
|
Is there really no one available to checkout these 2 lines of code? To get them merged and distributed to the community? 👀 |
pastelcode
approved these changes
Apr 4, 2023
Maxvyr
approved these changes
Apr 6, 2023
|
@MarkOSullivan94, can you quickly take a look at this, cuz lots of apps are on hold due to app store restrictions. |
|
Thanks for the ping @OutdatedGuy! Merging this in now and will have a release shortly available |
MarkOSullivan94
approved these changes
Apr 7, 2023
|
Thank you for submitting this change @mike-500 ❤️ |
|
Also big thank you to everyone who tested the change - makes it a lot quicker for me to ship this change ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #462.
After the dependency upgrade from image 3.x.x to image 4.0.x the remove alpha for iOS no longer works and builds are rejected from the App Store.
The fix is from the example here: brendan-duncan/image#447 (comment).
All tests are passing.