Added customizable timer to hide controls #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegotori
reviewed
Apr 13, 2022
diegotori
reviewed
Apr 13, 2022
diegotori
reviewed
Apr 13, 2022
diegotori
reviewed
Apr 13, 2022
diegotori
reviewed
Apr 13, 2022
lib/src/chewie_player.dart
Outdated
| ); | ||
| } | ||
|
|
||
| static const defaultTimer = Duration(seconds: 3); |
There was a problem hiding this comment.
Rename this to defaultHideControlsTimer.
diegotori
reviewed
Apr 13, 2022
lib/src/chewie_player.dart
Outdated
| @@ -487,6 +492,9 @@ class ChewieController extends ChangeNotifier { | |||
| /// Defines if push/pop navigations use the rootNavigator | |||
| final bool useRootNavigator; | |||
|
|
|||
| /// Define the time interval before the video controls are hidden | |||
There was a problem hiding this comment.
Replace with.
/// Defines the [Duration] before the video controls are hidden. By default, this is set to three seconds.
|
LGTM. |
diegotori
added a commit
that referenced
this pull request
Apr 14, 2022
codenameakshay
pushed a commit
to qoohoo-app/chewie
that referenced
this pull request
Aug 29, 2022
lg8294
added a commit
to lg8294/chewie
that referenced
this pull request
Sep 22, 2022
* commit '3948d23733638d8a58ea5ff065abfe96934d2373': (110 commits) Version 1.3.4. Addresses PRs fluttercommunity#623 and fluttercommunity#646. Update pubspec.yaml version updates fix: change video type fix: format and migration artifacts fix: apply diegotori suggestion feat: added support for apple and desktop version feat: Make progressIndicatorDelay a Duration fix: simplify assignation fix: name fix: let the android player buffer before seeking once more fix: removed old code fix: lint feat: added method to set progress delay feat: added example debug feat: add a delay before displaying progress indicator Version 1.3.3. Adds PR fluttercommunity#634. Update pubspec.yaml chore: remove unused dependency Version 1.3.2. Adds PR fluttercommunity#626. ... # Conflicts: # example/ios/Runner.xcodeproj/project.pbxproj # example/ios/Runner.xcodeproj/xcshareddata/xcschemes/Runner.xcscheme # example/ios/Runner/Info.plist # example/lib/main.dart # example/pubspec.yaml # lib/src/chewie_player.dart # pubspec.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The time interval without user interactions after which the controls are hidden is now customizable.
Negative time intervals are ignored, defaulting to a 3 seconds timer. closes #595