🐛 Fix disposed provider throwing error when fetching assets #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeGoffMael
commented
Sep 13, 2023
Comment on lines
+67
to
+72
| @override | ||
| void notifyListeners() { | ||
| if (_mounted) { | ||
| super.notifyListeners(); | ||
| } | ||
| } |
There was a problem hiding this comment.
This part is actually optional since it is not needed to fix #492 issue.
However, notifyListeners() will throw an exception if the provider was disposed, so i thought it was still good to put a flag on it.
|
I there anything needed to merge this PR ? (my commits were not verified but it should now be fine in my next commits) |
Nope. Just forgot to press the button. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #492