refactor Result class, remove asOk and asError #2542
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the PR for the Result pattern implementation (flutter/website#11444) @parlough recommended that
asError
andasOk
should be not be used, and instead we should use proper exhaustiveness checking.This PR removes the two "convenience" methods and refactors code.
In some cases, it was enough with writing a proper
if
clause, while in others it was necessary to use aswitch
.Still, they are present in the
testing
folder, as they can be useful for testing purposes.Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-devrel channel on Discord.