Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[webview_flutter] Exposes WebResourceErrorType #6877

Merged
merged 1 commit into from
Dec 23, 2022
Merged

[webview_flutter] Exposes WebResourceErrorType #6877

merged 1 commit into from
Dec 23, 2022

Conversation

bparrishMines
Copy link
Contributor

@bparrishMines bparrishMines commented Dec 23, 2022 •
edited
Loading

Fixes flutter/flutter#117556

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added the p: webview_flutter Edits files for a webview_flutter plugin label Dec 23, 2022
@bparrishMines bparrishMines changed the title expose webresourceeerrortype [webview_flutter] Exposes WebResourceErrorType Dec 23, 2022
@bparrishMines bparrishMines mentioned this pull request Dec 23, 2022
Closed
stuartmorgan
stuartmorgan approved these changes Dec 23, 2022
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bparrishMines bparrishMines added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 23, 2022
@auto-submit auto-submit bot merged commit 9dc0534 into flutter:main Dec 23, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 26, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 26, 2022
@engine-flutter-autoroll
9dc053428 expose webresourceeerrortype (flutter/plugins#6877)
521c077
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Dec 26, 2022
@engine-flutter-autoroll
Roll Plugins from 94a54bf3acdf to 3eba2bf698e5 (4 revisions) (#117653)
ae292cc 
* 986b16a2d Roll Flutter from 9fb1ae8 to a45a2f3 (19 revisions) (flutter/plugins#6879)

* 9dc053428 expose webresourceeerrortype (flutter/plugins#6877)

* 9ee9db676 [image_picker] Fix check for iOS 14+ authorization status (flutter/plugins#6845)

* 3eba2bf69 Roll Flutter from a45a2f3 to e766ad0 (7 revisions) (flutter/plugins#6880)
loic-sharma pushed a commit to fluttergithubbot/flutter that referenced this pull request Jan 6, 2023
@engine-flutter-autoroll @loic-sharma
Roll Plugins from 94a54bf3acdf to 3eba2bf698e5 (4 revisions) (flutter…
eb8e40d 
…#117653)

* 986b16a2d Roll Flutter from 9fb1ae8 to a45a2f3 (19 revisions) (flutter/plugins#6879)

* 9dc053428 expose webresourceeerrortype (flutter/plugins#6877)

* 9ee9db676 [image_picker] Fix check for iOS 14+ authorization status (flutter/plugins#6845)

* 3eba2bf69 Roll Flutter from a45a2f3 to e766ad0 (7 revisions) (flutter/plugins#6880)
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
@engine-flutter-autoroll @gspencergoog
Roll Plugins from 94a54bf3acdf to 3eba2bf698e5 (4 revisions) (flutter…
cd2f851 
…#117653)

* 986b16a2d Roll Flutter from 9fb1ae8 to a45a2f3 (19 revisions) (flutter/plugins#6879)

* 9dc053428 expose webresourceeerrortype (flutter/plugins#6877)

* 9ee9db676 [image_picker] Fix check for iOS 14+ authorization status (flutter/plugins#6845)

* 3eba2bf69 Roll Flutter from a45a2f3 to e766ad0 (7 revisions) (flutter/plugins#6880)
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
@bparrishMines @mauricioluz
expose webresourceeerrortype (flutter#6877)
b659181
@bparrishMines bparrishMines deleted the expose_error_type branch January 31, 2023 19:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stuartmorgan stuartmorgan stuartmorgan approved these changes

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: webview_flutter Edits files for a webview_flutter plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[webview_flutter] Expose WebResourceErrorType
2 participants
@bparrishMines @stuartmorgan