This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[webview_flutter] Android implementation of loadFlutterAsset
method.
#4581
Merged
fluttergithubbot
merged 7 commits into
flutter:master
from
Baseflow:webview_android_load_asset
Dec 7, 2021
Merged
[webview_flutter] Android implementation of loadFlutterAsset
method.
#4581
fluttergithubbot
merged 7 commits into
flutter:master
from
Baseflow:webview_android_load_asset
Dec 7, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the `loadFlutterAsset` method to the platform interface. This method, when implemented, is responsible for correctly loading HTML content that is part of the Flutter asset bundle.
github-actions
bot
added
p: webview_flutter
Edits files for a webview_flutter plugin
platform-android
labels
Dec 6, 2021
mvanbeusekom
force-pushed
the
webview_android_load_asset
branch
from
December 6, 2021 14:53
a3c2a60
to
67ca6ce
Compare
bparrishMines
approved these changes
Dec 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
stuartmorgan
suggested changes
Dec 6, 2021
...er_android/android/src/main/java/io/flutter/plugins/webviewflutter/WebViewFlutterPlugin.java
Show resolved
Hide resolved
...id/src/test/java/io/flutter/plugins/webviewflutter/PluginBindingFlutterAssetManagerTest.java
Show resolved
Hide resolved
...ndroid/src/test/java/io/flutter/plugins/webviewflutter/RegistrarFlutterAssetManagerTest.java
Show resolved
Hide resolved
packages/webview_flutter/webview_flutter_android/lib/webview_android_widget.dart
Show resolved
Hide resolved
mvanbeusekom
force-pushed
the
webview_android_load_asset
branch
from
December 6, 2021 20:10
08023b2
to
525d9a7
Compare
stuartmorgan
approved these changes
Dec 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mvanbeusekom
added
the
waiting for tree to go green
(Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
label
Dec 6, 2021
This pull request is not suitable for automatic merging in its current state.
|
fluttergithubbot
removed
the
waiting for tree to go green
(Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
label
Dec 6, 2021
mvanbeusekom
added
the
waiting for tree to go green
(Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
label
Dec 6, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 7, 2021
amantoux
pushed a commit
to amantoux/plugins
that referenced
this pull request
Dec 11, 2021
KyleFin
pushed a commit
to KyleFin/plugins
that referenced
this pull request
Dec 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
cla: yes
p: webview_flutter
Edits files for a webview_flutter plugin
platform-android
waiting for tree to go green
(Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android implementation of the
loadFlutterAsset
method of the platform interface.Related issue: flutter/flutter#27086
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.md
to add a description of the change, [following repository CHANGELOG style].///
).