Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[webview_flutter] Implement loadRequest in iOS package. #4480

Merged
merged 4 commits into from
Nov 10, 2021
Merged

[webview_flutter] Implement loadRequest in iOS package. #4480

merged 4 commits into from
Nov 10, 2021

Conversation

BeMacized
Copy link
Contributor

This PR is a partial resubmission of my colleague's PR: #4169.

It implements the loadRequest method added in #4450 for the iOS package.

Related issue:

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter]. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

@google-cla
Copy link

google-cla bot commented Nov 5, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Nov 5, 2021
@github-actions github-actions bot added p: webview_flutter Edits files for a webview_flutter plugin platform-ios labels Nov 5, 2021
@BeMacized
Copy link
Contributor Author

@googlebot I consent.

@google-cla
Copy link

google-cla bot commented Nov 5, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@ydag
Copy link
Contributor

ydag commented Nov 5, 2021

@googlebot I consent.

@google-cla google-cla bot added cla: yes and removed cla: no labels Nov 5, 2021
mvanbeusekom
mvanbeusekom suggested changes Nov 9, 2021
View reviewed changes
Copy link
Contributor

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, I have two small points

packages/webview_flutter/webview_flutter_wkwebview/ios/Classes/FlutterWebView.h Outdated Show resolved Hide resolved
packages/webview_flutter/webview_flutter_wkwebview/ios/Classes/FlutterWebView.m Show resolved Hide resolved
mvanbeusekom
mvanbeusekom approved these changes Nov 10, 2021
View reviewed changes
Copy link
Contributor

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BeMacized BeMacized added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Nov 10, 2021
@fluttergithubbot fluttergithubbot merged commit 0f90d24 into flutter:master Nov 10, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 10, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 10, 2021
@engine-flutter-autoroll
0f90d24 [webview_flutter] Implement loadRequest in iOS package. (flut…
cdf4c04 
…ter/plugins#4480)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 10, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 10, 2021
@engine-flutter-autoroll
0f90d24 [webview_flutter] Implement loadRequest in iOS package. (flut…
ef03084 
…ter/plugins#4480)
@mvanbeusekom mvanbeusekom deleted the webview_flutter/request_url_native_ios branch November 11, 2021 07:51
amantoux pushed a commit to amantoux/plugins that referenced this pull request Dec 11, 2021
@BeMacized @amantoux
[webview_flutter] Implement loadRequest in iOS package. (flutter#4480)
50735d7
KyleFin pushed a commit to KyleFin/plugins that referenced this pull request Dec 21, 2021
@BeMacized @KyleFin
[webview_flutter] Implement loadRequest in iOS package. (flutter#4480)
6a48a6a
mvanbeusekom added a commit to Baseflow/flutter-plugins that referenced this pull request Feb 2, 2022
@mvanbeusekom
Refactored tests to expose private interface in separate test header.
3f914df 
Refactored the existing unit tests to expose private interfaces in a
separate test header instead of an inline interface. This was first
introduced in the google_sign_in plugin (flutter#4157) and after that also
applied in the camera plugin (flutter#4426) and the webview_flutter plugin
(flutter#4480).

This commit also removed several obsolete `OCMStub` declarations.
@mvanbeusekom mvanbeusekom mentioned this pull request Feb 2, 2022
Merged
11 tasks
mvanbeusekom added a commit to Baseflow/flutter-plugins that referenced this pull request Feb 2, 2022
@mvanbeusekom
Refactored tests to expose private interface in separate test header.
f963f12 
Refactored the existing unit tests to expose private interfaces in a
separate test header instead of an inline interface. This was first
introduced in the google_sign_in plugin (flutter#4157) and after that also
applied in the camera plugin (flutter#4426) and the webview_flutter plugin
(flutter#4480).

This commit also removed several obsolete `OCMStub` declarations.
mvanbeusekom added a commit to Baseflow/flutter-plugins that referenced this pull request Feb 2, 2022
@mvanbeusekom
Refactored tests to expose private interface in separate test header.
344a712 
Refactored the existing unit tests to expose private interfaces in a
separate test header instead of an inline interface. This was first
introduced in the google_sign_in plugin (flutter#4157) and after that also
applied in the camera plugin (flutter#4426) and the webview_flutter plugin
(flutter#4480).

This commit also removed several obsolete `OCMStub` declarations.
mvanbeusekom added a commit to Baseflow/flutter-plugins that referenced this pull request Feb 2, 2022
@mvanbeusekom
Refactored tests to expose private interface in separate test header.
c37810b 
Refactored the existing unit tests to expose private interfaces in a
separate test header instead of an inline interface. This was first
introduced in the google_sign_in plugin (flutter#4157) and after that also
applied in the camera plugin (flutter#4426) and the webview_flutter plugin
(flutter#4480).
mvanbeusekom added a commit to Baseflow/flutter-plugins that referenced this pull request Feb 2, 2022
@mvanbeusekom
Refactored tests to expose private interface in separate test header.
12a3e7c 
Refactored the existing unit tests to expose private interfaces in a
separate test header instead of an inline interface. This was first
introduced in the google_sign_in plugin (flutter#4157) and after that also
applied in the camera plugin (flutter#4426) and the webview_flutter plugin
(flutter#4480).
mvanbeusekom added a commit to Baseflow/flutter-plugins that referenced this pull request Feb 2, 2022
@mvanbeusekom
Refactored tests to expose private interface in separate test header.
bd955e9 
Refactored the existing unit tests to expose private interfaces in a
separate test header instead of an inline interface. This was first
introduced in the google_sign_in plugin (flutter#4157) and after that also
applied in the camera plugin (flutter#4426) and the webview_flutter plugin
(flutter#4480).
mvanbeusekom added a commit to Baseflow/flutter-plugins that referenced this pull request Feb 7, 2022
@mvanbeusekom
Refactored tests to expose private interface in separate test header.
441dea1 
Refactored the existing unit tests to expose private interfaces in a
separate test header instead of an inline interface. This was first
introduced in the google_sign_in plugin (flutter#4157) and after that also
applied in the camera plugin (flutter#4426) and the webview_flutter plugin
(flutter#4480).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mvanbeusekom mvanbeusekom mvanbeusekom approved these changes

Assignees
No one assigned
Labels
cla: yes p: webview_flutter Edits files for a webview_flutter plugin platform-ios waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BeMacized @ydag @mvanbeusekom @fluttergithubbot