Update README.md #8132
Draft
Update README.md #8132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Readme currently mentions `dart:html` but I'm pretty sure it's been migrated over to `package:web` based on https://github.com/flutter/packages/blob/59a1067db64aad91ba1b56c77d6dbc1aa5cf2481/packages/cross_file/test/x_file_html_test.dart#L14C1-L15C1
|
Thanks for the submission! In the future, please do not delete the checklist that is in the PR template; it is there for a reason. This PR is missing required elements described in the checklist (I’ve restored it to the PR description), which need to be addressed before it moves forward with review. I am marking the PR as a Draft. Please review the checklist, updating the PR as appropriate, and when that’s complete please feel free to mark the PR as ready for review. |
|
Looks good to me, but please complete the PR so the changes can be published to pub.dev! Look at the checklist! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readme currently mentions (legacy)
dart:htmlbut I'm pretty sure package has been migrated over topackage:webbased on https://github.com/flutter/packages/blob/59a1067db64aad91ba1b56c77d6dbc1aa5cf2481/packages/cross_file/test/x_file_html_test.dart#L14C1-L15C1Readme should reflect package's web dependencies
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.