Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group dependabot updates for gradle test dependencies #8100

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Nov 14, 2024

After #8048 I was expecting dependabot to update all packages given a particular dependency bump, but that doesn't seem to be happening. For example #8097 only updated shared_preferences_android.

So let's try adding groups to see if that does it. Group the obvious test dependencies together.

Part of flutter/flutter#148098

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman self-assigned this Nov 14, 2024
@@ -102,6 +102,14 @@ updates:
schedule:
interval: "weekly"
open-pull-requests-limit: 10
groups:
test-dependencies:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This group name is arbitrary, it's not a special dependabot keyword.

@stuartmorgan
Copy link
Contributor

For example #8097 only updated shared_preferences_android.

That appears to be the only package with that dependency. So it may still be working as expected?

@jmagman
Copy link
Member Author

jmagman commented Nov 18, 2024

For example #8097 only updated shared_preferences_android.

That appears to be the only package with that dependency. So it may still be working as expected?

Hm, you're right, and I don't see any other new and open ones that would have updated multiple packages.
I'm going to close a few (trivial) old open dependabot PRs and see what it recreates on the next round. Moving this to draft.

@stuartmorgan
Copy link
Contributor

#8170 and #8168 are the same dependency in different packages, so it looks like we do need groups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants