[webview_flutter] Fix macOS 14+ test hangs #7953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting in macOS 14, webview_flutter integration tests hang due to being unable to connect to the test server. Based on local experimentation, in appears that we are not able to connect when binding to the "any" address, which gives us an IP address of 0.0.0.0, but using the loopback address (which is all we should need; the point is to accept local connections from the test itself) does work. Fixes flutter/flutter#157449
stuartmorgan
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 30, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 30, 2024
flutter/packages@028027e...7cc1caa 2024-10-30 [email protected] [tool] Update build-all app creation (flutter/packages#7955) 2024-10-30 [email protected] Disable two lint rules which are being removed. (flutter/packages#7959) 2024-10-29 [email protected] Bump `path_provider_android` to `^2.2.5` due to Android v1 embedder. (flutter/packages#7935) 2024-10-29 [email protected] Roll Flutter from 3fb95c7 to 42132e8 (19 revisions) (flutter/packages#7958) 2024-10-29 [email protected] [webview_flutter] Fix macOS 14+ test hangs (flutter/packages#7953) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting in macOS 14, webview_flutter integration tests hang due to being unable to connect to the test server. Based on local experimentation, in appears that we are not able to connect when binding to the "any" address, which gives us an IP address of 0.0.0.0, but using the loopback address (which is all we should need; the point is to accept local connections from the test itself) does work.
Since our test fleet is a mixed macOS 13/14 fleet, this should fix flaky timeouts of macOS platform tests in CI, in addition to fixing local runs.
Fixes flutter/flutter#157449
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).