[interactive_media_ads] Adds support for mid-roll ads #7407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bparrishMines
commented
Sep 10, 2024
| @@ -79,13 +80,18 @@ base class AndroidAdsLoader extends PlatformAdsLoader { | |||
| } | |||
|
|
|||
| @override | |||
| Future<void> requestAds(AdsRequest request) async { | |||
| Future<void> requestAds(PlatformAdsRequest request) async { | |||
There was a problem hiding this comment.
The platform implementations haven't been exposed yet, so this shouldn't be a breaking change.
bparrishMines
changed the title
bparrishMines
commented
Sep 11, 2024
|
|
||
| if (_adsManager != null) { | ||
| _contentProgressTimer = Timer.periodic( | ||
| const Duration(milliseconds: 500), |
There was a problem hiding this comment.
@harold1208 @stuartmorgan What are your thoughts on the interval to be used here in the example? This works for me on Android and iOS, but this is a Flutter specific workaround to handle the SDK running on a separate thread.
There was a problem hiding this comment.
For context, this timer updates the SDK of the progress of the content video with this being the interval between updates.
There was a problem hiding this comment.
Per our offline discussion with the IMA team, a 200ms interval would be the ideal value.
harold1208
reviewed
Sep 13, 2024
stuartmorgan
approved these changes
Sep 16, 2024
bparrishMines
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 18, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 18, 2024
flutter/packages@4f2b9cd...c7406b3 2024-09-17 [email protected] [interactive_media_ads] Adds support for mid-roll ads (flutter/packages#7407) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
ContentProgressProviderand addsAdsRequest.contentProgressProviderfield.This changes the platform interface
AdsRequesttoPlatformAdsRequest, so thePlatformContentProgressProvidercan be passed to it. And the app-facingAdsRequestcan take aContentProgressProver.Fixes flutter/flutter#154261
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.