Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose registered widget libraries and local widget library widgets. #5936

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

johnmccutchan
Copy link
Contributor

This exposes the necessary information to allow rfwpg to display registered libraries and widgets in a list or tree.

@johnmccutchan johnmccutchan requested a review from Hixie as a code owner January 19, 2024 07:18
@github-actions github-actions bot added the p: rfw Remote Flutter Widgets label Jan 19, 2024
packages/rfw/test/runtime_test.dart Outdated Show resolved Hide resolved
packages/rfw/lib/src/flutter/runtime.dart Outdated Show resolved Hide resolved
packages/rfw/lib/src/flutter/runtime.dart Outdated Show resolved Hide resolved
packages/rfw/test/runtime_test.dart Outdated Show resolved Hide resolved
packages/rfw/test/runtime_test.dart Outdated Show resolved Hide resolved
packages/rfw/test/runtime_test.dart Outdated Show resolved Hide resolved
@johnmccutchan johnmccutchan force-pushed the rfw_access_ branch 4 times, most recently from 35732f6 to 40fd813 Compare January 19, 2024 09:02
@johnmccutchan johnmccutchan requested a review from Hixie January 19, 2024 09:03
@johnmccutchan johnmccutchan added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 19, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 19, 2024
Copy link
Contributor

auto-submit bot commented Jan 19, 2024

auto label is removed for flutter/packages/5936, due to This PR has not met approval requirements for merging. Changes were requested by {Hixie}, please make the needed changes and resubmit this PR.
The PR author is a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

  • Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

Copy link
Contributor

auto-submit bot commented Jan 19, 2024

auto label is removed for flutter/packages/5936, due to - The status or check suite Linux repo_tools_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

packages/rfw/CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Hixie Hixie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo minor comments

@johnmccutchan
Copy link
Contributor Author

Thanks all for the reviews!

This exposes the necessary information to allow rfwpg to display registered
libraries and widgets in a list or tree.

Include tests.
@johnmccutchan johnmccutchan added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 19, 2024
@auto-submit auto-submit bot merged commit 7901015 into flutter:main Jan 19, 2024
80 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 22, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jan 22, 2024
flutter/packages@129e08c...e4cbf23

2024-01-21 [email protected] Roll Flutter from ddf60fb to 5dea6b9 (5 revisions) (flutter/packages#5951)
2024-01-21 [email protected] Update platform label rules for shared iOS/macOS (flutter/packages#5801)
2024-01-20 [email protected] [pigeon] Support other hosts in generated file CI checks (flutter/packages#5944)
2024-01-20 [email protected] [pigeon] Improve style of generated Swift code (flutter/packages#5938)
2024-01-20 [email protected] Roll Flutter from 684247a to ddf60fb (12 revisions) (flutter/packages#5949)
2024-01-20 [email protected] [camera]fix a sample buffer memory leak on pause resume recording (flutter/packages#5927)
2024-01-19 [email protected] [ci] Run Swift formatter and linter during CI formatting (flutter/packages#5928)
2024-01-19 [email protected] Manual roll Flutter from f77f824 to 684247a (39 revisions) (flutter/packages#5948)
2024-01-19 [email protected] Expose registered widget libraries and local widget library widgets. (flutter/packages#5936)
2024-01-19 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.1.0 to 4.2.0 (flutter/packages#5937)
2024-01-19 [email protected] Manual roll Flutter (stable) from ef1af02 to 67457e6 (1 revision) (flutter/packages#5932)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
…lutter#5936)

This exposes the necessary information to allow rfwpg to display registered libraries and widgets in a list or tree.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: rfw Remote Flutter Widgets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants